Discussion:
Tag duplicate messages with notmuch insert
Thomas Schneider
2018-10-15 07:38:43 UTC
Permalink
If the new message is a duplicate of an existing message in the
database (it has same Message-ID), it will be added to the maildir
folder and notmuch database, but the tags will not be changed.
It might however be desired to apply the new tags even when the message
is a duplicate. How complicated would it be to implement this?
David Bremner
2018-10-15 09:42:19 UTC
Permalink
Post by Thomas Schneider
If the new message is a duplicate of an existing message in the
database (it has same Message-ID), it will be added to the maildir
folder and notmuch database, but the tags will not be changed.
It might however be desired to apply the new tags even when the message
is a duplicate. How complicated would it be to implement this?
It doesn't look especially hard, assuming the obvious small change to
add_file() in notmuch-insert.c works. I didn't look at the equivalent
code path in notmuch-new.c. Presumably you'd want them both to behave
the same way.

d
David Bremner
2018-10-15 09:52:02 UTC
Permalink
Post by David Bremner
Post by Thomas Schneider
If the new message is a duplicate of an existing message in the
database (it has same Message-ID), it will be added to the maildir
folder and notmuch database, but the tags will not be changed.
It might however be desired to apply the new tags even when the message
is a duplicate. How complicated would it be to implement this?
It doesn't look especially hard, assuming the obvious small change to
add_file() in notmuch-insert.c works. I didn't look at the equivalent
code path in notmuch-new.c. Presumably you'd want them both to behave
the same way.
Just to be clear, I wasn't commenting on whether it was the right thing
to do or not, just whether it would be hard. It seems likely to be
annoying to at least some people to have messages show up as unread
again (or whatever the tags are) when new copies arrive.

d
Thomas Schneider
2018-10-15 11:00:29 UTC
Permalink
Post by David Bremner
Just to be clear, I wasn't commenting on whether it was the right thing
to do or not, just whether it would be hard. It seems likely to be
annoying to at least some people to have messages show up as unread
again (or whatever the tags are) when new copies arrive.
Oh, I meant as an option of course, with a default to keep the current
behaviour.
Martin Jambor
2018-10-15 11:25:16 UTC
Permalink
Hi,
Post by David Bremner
Post by David Bremner
Post by Thomas Schneider
If the new message is a duplicate of an existing message in the
database (it has same Message-ID), it will be added to the maildir
folder and notmuch database, but the tags will not be changed.
It might however be desired to apply the new tags even when the message
is a duplicate. How complicated would it be to implement this?
It doesn't look especially hard, assuming the obvious small change to
add_file() in notmuch-insert.c works. I didn't look at the equivalent
code path in notmuch-new.c. Presumably you'd want them both to behave
the same way.
Just to be clear, I wasn't commenting on whether it was the right thing
to do or not, just whether it would be hard. It seems likely to be
annoying to at least some people to have messages show up as unread
again (or whatever the tags are) when new copies arrive.
[If enabled,] such messages should get only the +new tag, not the +unread
tag. Or whatever the user configured, of course.

Martin

Loading...