[PATCH] Avoid spurious gcc warning in debugger.c

[Daniel Kahn Gillmor]

Without this patch, gcc 8.2.0-7 complains:

debugger.c: In function ‘debugger_is_active’:
debugger.c:40:24: warning: passing argument 2 to restrict-qualified parameter aliases with argument 1 [-Wrestrict]
if (readlink (buf, buf, sizeof (buf)) != -1 &&
~~~ ^~~

This is pretty silly, but it seems simplest to just avoid passing the
same buffer to readlink as both pathname and buf.
---
debugger.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/debugger.c b/debugger.c
index 5cb38ac4..0febf170 100644
--- a/debugger.c
+++ b/debugger.c
@@ -32,13 +32,14 @@ bool
debugger_is_active (void)
{
char buf[1024];
+ char buf2[1024];

if (RUNNING_ON_VALGRIND)
return true;

sprintf (buf, "/proc/%d/exe", getppid ());
- if (readlink (buf, buf, sizeof (buf)) != -1 &&
- strncmp (basename (buf), "gdb", 3) == 0)
+ if (readlink (buf, buf2, sizeof (buf2)) != -1 &&
+ strncmp (basename (buf2), "gdb", 3) == 0)
{
return true;
}

[David Bremner]

Post by Daniel Kahn Gillmor
debugger.c:40:24: warning: passing argument 2 to restrict-qualified parameter aliases with argument 1 [-Wrestrict]
if (readlink (buf, buf, sizeof (buf)) != -1 &&
~~~ ^~~

There seems to be some overlap with dme's recent patch

id:20181004094545.18710-1-***@dme.org

Could one or both of you maybe produce a merged series?

d

[David Edmondson]

Post by David Bremner

Post by Daniel Kahn Gillmor
debugger.c:40:24: warning: passing argument 2 to restrict-qualified parameter aliases with argument 1 [-Wrestrict]
if (readlink (buf, buf, sizeof (buf)) != -1 &&
~~~ ^~~

There seems to be some overlap with dme's recent patch
Could one or both of you maybe produce a merged series?

The change is really the same.

dme.

[Daniel Kahn Gillmor]

Post by David Edmondson

Post by David Bremner

Post by Daniel Kahn Gillmor
debugger.c:40:24: warning: passing argument 2 to restrict-qualified parameter aliases with argument 1 [-Wrestrict]
if (readlink (buf, buf, sizeof (buf)) != -1 &&
~~~ ^~~

There seems to be some overlap with dme's recent patch
Could one or both of you maybe produce a merged series?

The change is really the same.

i'm fine with either one as well. thanks, and sorry that i missed dme's
proposal when preparing this one.

--dkg

[David Bremner]

Post by Daniel Kahn Gillmor
debugger.c:40:24: warning: passing argument 2 to restrict-qualified parameter aliases with argument 1 [-Wrestrict]
if (readlink (buf, buf, sizeof (buf)) != -1 &&
~~~ ^~~
This is pretty silly, but it seems simplest to just avoid passing the
same buffer to readlink as both pathname and buf.

pushed,

d